🐛 Fix standardize exact matches #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zethson <lukas.heumos@posteo.net>
|
Great! I'm curious: is the "search on synonyms" logic duplicated across lamindb and bionty? If so, is there still any reason to have this after integrating bionty with lamindb? (I guess this is mostly a question for @sunnyosun) |
|
I think it doesn't matter much as i will also port the search logic from |
That means it's in fact duplicated right now, which was evidently very error prone. Good that this gets consolidated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to @felix0097 issue
The newly added test failed before and is what he ran into in his instance. The new implementation:
mapped_df["__agg__"]) with thefield_map.index.